Use g_rename directly instead of rename.

Wed, 30 Oct 2019 22:19:59 -0400

author
Elliott Sales de Andrade <qulogic@pidgin.im>
date
Wed, 30 Oct 2019 22:19:59 -0400
changeset 40093
dd7183cf0a71
parent 40092
5f6a8bcd216d
child 40094
8e6d91e4dd8f

Use g_rename directly instead of rename.

This removes the need for extra compatibility macros, and thus hacks to
_undo_ the macro too.

libpurple/prefs.c file | annotate | diff | comparison | revisions
libpurple/protocols/zephyr/ZVariables.c file | annotate | diff | comparison | revisions
libpurple/win32/libc_interface.h file | annotate | diff | comparison | revisions
--- a/libpurple/prefs.c	Wed Oct 30 22:04:59 2019 -0400
+++ b/libpurple/prefs.c	Wed Oct 30 22:19:59 2019 -0400
@@ -1308,11 +1308,6 @@
 {
 	struct purple_pref *oldpref, *newpref;
 
-/* win32dep.h causes rename to be defined as wpurple_rename, so we need to undefine it here */
-#if defined(_WIN32) && defined(rename)
-#undef rename
-#endif
-
 	PURPLE_PREFS_UI_OP_CALL(rename, oldname, newname);
 
 	oldpref = find_pref(oldname);
--- a/libpurple/protocols/zephyr/ZVariables.c	Wed Oct 30 22:04:59 2019 -0400
+++ b/libpurple/protocols/zephyr/ZVariables.c	Wed Oct 30 22:19:59 2019 -0400
@@ -87,7 +87,7 @@
     	g_free(varfile);
 	return(EIO);		/* can't rely on errno */
     }
-    if (rename(varfilebackup, varfile)) {
+    if (g_rename(varfilebackup, varfile)) {
 	g_free(varfilebackup);
 	g_free(varfile);
 	return (errno);
@@ -127,7 +127,7 @@
 	g_free(varfile);
 	return(EIO);		/* errno isn't reliable */
     }
-    if (rename(varfilebackup, varfile)) {
+    if (g_rename(varfilebackup, varfile)) {
 	g_free(varfilebackup);
 	g_free(varfile);
 	return (errno);
--- a/libpurple/win32/libc_interface.h	Wed Oct 30 22:04:59 2019 -0400
+++ b/libpurple/win32/libc_interface.h	Wed Oct 30 22:19:59 2019 -0400
@@ -142,9 +142,6 @@
 #  define vsnprintf _vsnprintf
 #endif
 
-#define rename( oldname, newname ) \
-g_rename( oldname, newname )
-
 /* time.h */
 /* XXX: it may be also defined by pthread.h */
 #undef localtime_r

mercurial