Sat, 29 Dec 2012 23:34:35 -0800
Actually remove purple_conversation_do_command
We don't call this function ourselves. Was it intended for plugins or
something...? I already added an entry for this to ChangeLog.API,
so if we revert this comment we should revert that commit, too.
| libpurple/conversation.c | file | annotate | diff | comparison | revisions | |
| libpurple/conversation.h | file | annotate | diff | comparison | revisions |
--- a/libpurple/conversation.c Sat Dec 29 23:30:43 2012 -0800 +++ b/libpurple/conversation.c Sat Dec 29 23:34:35 2012 -0800 @@ -2501,18 +2501,6 @@ return conv->ui_data; } - -gboolean -purple_conversation_do_command(PurpleConversation *conv, const gchar *cmdline, - const gchar *markup, gchar **error) -{ - char *mark = (markup && *markup) ? NULL : g_markup_escape_text(cmdline, -1), *err = NULL; - PurpleCmdStatus status = purple_cmd_do_command(conv, cmdline, mark ? mark : markup, error ? error : &err); - g_free(mark); - g_free(err); - return (status == PURPLE_CMD_STATUS_OK); -} - void * purple_conversations_get_handle(void) {
--- a/libpurple/conversation.h Sat Dec 29 23:30:43 2012 -0800 +++ b/libpurple/conversation.h Sat Dec 29 23:34:35 2012 -0800 @@ -1361,19 +1361,6 @@ */ GList * purple_conversation_get_extended_menu(PurpleConversation *conv); -/** - * Perform a command in a conversation. Similar to @see purple_cmd_do_command - * - * @param conv The conversation. - * @param cmdline The entire command including the arguments. - * @param markup @c NULL, or the formatted command line. - * @param error If the command failed errormsg is filled in with the appropriate error - * message, if not @c NULL. It must be freed by the caller with g_free(). - * - * @return @c TRUE if the command was executed successfully, @c FALSE otherwise. - */ -gboolean purple_conversation_do_command(PurpleConversation *conv, const gchar *cmdline, const gchar *markup, gchar **error); - /*@}*/ /**************************************************************************/