disapproval of revision '48018e2c0eeccd0d745b803d282556e69b6b8311' next.minor

Wed, 30 Apr 2008 11:27:17 +0000

author
Sadrul Habib Chowdhury <sadrul@pidgin.im>
date
Wed, 30 Apr 2008 11:27:17 +0000
branch
next.minor
changeset 22925
f1ee5eb82c14
parent 22924
48018e2c0eec
child 23272
f9243c62f2c3

disapproval of revision '48018e2c0eeccd0d745b803d282556e69b6b8311'

This really needs to happen with the appropriate magic necessary to allow
adding newer functions when necessary without forcing a bump in the
major. I am not necessarily succumbing to 'fear of incrementing a version
number' or anything, I just don't think this particular feature is
important or useful enough. I would be interested to see if there's still
any confusion left after the change from 'Screenname' to 'Username'.

libpurple/protocols/msn/msn.c file | annotate | diff | comparison | revisions
libpurple/protocols/msnp9/msn.c file | annotate | diff | comparison | revisions
libpurple/protocols/myspace/myspace.c file | annotate | diff | comparison | revisions
libpurple/prpl.h file | annotate | diff | comparison | revisions
pidgin/gtkaccount.c file | annotate | diff | comparison | revisions
--- a/libpurple/protocols/msn/msn.c	Wed Apr 30 03:24:35 2008 +0000
+++ b/libpurple/protocols/msn/msn.c	Wed Apr 30 11:27:17 2008 +0000
@@ -132,9 +132,6 @@
 	return list;
 }
 
-const char *msn_get_login_label() {
-	return _("E-mail Address...");
-}
 
 static PurpleCmdRet
 msn_cmd_nudge(PurpleConversation *conv, const gchar *cmd, gchar **args, gchar **error, void *data)
@@ -2309,7 +2306,9 @@
 	NULL,					/* unregister_user */
 	msn_send_attention,                     /* send_attention */
 	msn_attention_types,                    /* attention_types */
-	msn_get_login_label			/* account_login_label */
+
+	/* padding */
+	NULL
 };
 
 static PurplePluginInfo info =
--- a/libpurple/protocols/msnp9/msn.c	Wed Apr 30 03:24:35 2008 +0000
+++ b/libpurple/protocols/msnp9/msn.c	Wed Apr 30 11:27:17 2008 +0000
@@ -134,10 +134,6 @@
 }
 
 
-const char *msn_get_login_label() {
-	return _("E-mail Address...");
-}
-
 static PurpleCmdRet
 msn_cmd_nudge(PurpleConversation *conv, const gchar *cmd, gchar **args, gchar **error, void *data)
 {
@@ -2151,7 +2147,9 @@
 	NULL,					/* unregister_user */
 	msn_send_attention,                     /* send_attention */
 	msn_attention_types,                    /* attention_types */
-	msn_get_login_label			/* account_login_label */
+
+	/* padding */
+	NULL
 };
 
 static PurplePluginInfo info =
--- a/libpurple/protocols/myspace/myspace.c	Wed Apr 30 03:24:35 2008 +0000
+++ b/libpurple/protocols/myspace/myspace.c	Wed Apr 30 11:27:17 2008 +0000
@@ -2449,10 +2449,6 @@
 	return normalized;
 }
 
-const char *msim_get_login_label() {
-	return _("E-mail Address...");
-}
-
 /** Return whether the buddy can be messaged while offline.
  *
  * The protocol supports offline messages in just the same way as online
@@ -3135,7 +3131,7 @@
 	NULL,                  /* unregister_user */
 	msim_send_attention,   /* send_attention */
 	msim_attention_types,  /* attention_types */
-	msim_get_login_label /* get screen name field title */
+	NULL                /* _purple_reserved4 */
 };
 
 
--- a/libpurple/prpl.h	Wed Apr 30 03:24:35 2008 +0000
+++ b/libpurple/prpl.h	Wed Apr 30 11:27:17 2008 +0000
@@ -398,11 +398,7 @@
 	gboolean (*send_attention)(PurpleConnection *gc, const char *username, guint type);
 	GList *(*get_attention_types)(PurpleAccount *acct);
 
-	/* This allows protocols to specify a more specific term for the "ScreenName" field
-	 * in the add account window. This helps avoid confusion for users using protocols
-	 * such as MySpace or MSN
-	 */
-	const char *(*account_login_label)(void);
+	void (*_purple_reserved4)(void);
 };
 
 #define PURPLE_IS_PROTOCOL_PLUGIN(plugin) \
--- a/pidgin/gtkaccount.c	Wed Apr 30 03:24:35 2008 +0000
+++ b/pidgin/gtkaccount.c	Wed Apr 30 11:27:17 2008 +0000
@@ -255,16 +255,6 @@
 	}
 }
 
-static gboolean
-screenname_focus_cb(GtkWidget *widget, GdkEventFocus *event, AccountPrefsDialog *dialog)
-{
-	if (!strcmp(gtk_entry_get_text(GTK_ENTRY(widget)),dialog->prpl_info->account_login_label())) {
-		gtk_entry_set_text(GTK_ENTRY(widget),"");
-		gtk_widget_modify_text(widget,GTK_STATE_NORMAL,NULL);
-	}
-	return FALSE;
-}
-
 static void
 screenname_changed_cb(GtkEntry *entry, AccountPrefsDialog *dialog)
 {
@@ -280,23 +270,6 @@
 	}
 }
 
-static gboolean
-screenname_nofocus_cb(GtkWidget *widget, GdkEventFocus *event, AccountPrefsDialog *dialog)
-{
-	GdkColor color = {0, 34952, 35466, 34181};
-	if (*gtk_entry_get_text(GTK_ENTRY(widget)) == '\0') {
-		/* We have to avoid hitting the screenname_changed_cb function 
-		 * because it enables buttons we don't want enabled yet ;)
-		 */
-		g_signal_handlers_block_by_func(widget, G_CALLBACK(screenname_changed_cb), dialog);
-		gtk_entry_set_text(GTK_ENTRY(widget),dialog->prpl_info->account_login_label());
-		/* Make sure we can hit it again */
-		g_signal_handlers_unblock_by_func(widget, G_CALLBACK(screenname_changed_cb), dialog);
-		gtk_widget_modify_text(widget,GTK_STATE_NORMAL,&color);
-	}
-	return FALSE;
-}
-
 static void
 icon_filesel_choose_cb(const char *filename, gpointer data)
 {
@@ -391,7 +364,6 @@
 	GList *user_splits;
 	GList *l, *l2;
 	char *username = NULL;
-	GdkColor color = {0, 34952, 35466, 34181};
 
 	if (dialog->protocol_menu != NULL)
 	{
@@ -438,15 +410,6 @@
 
 	add_pref_box(dialog, vbox, _("Screen _name:"), dialog->screenname_entry);
 
-	if (dialog->prpl_info->account_login_label) {
-		gtk_entry_set_text(dialog->screenname_entry,dialog->prpl_info->account_login_label());
-		g_signal_connect(G_OBJECT(dialog->screenname_entry), "focus-in-event",
-						G_CALLBACK(screenname_focus_cb), dialog);
-		g_signal_connect(G_OBJECT(dialog->screenname_entry), "focus-out-event",
-						G_CALLBACK(screenname_nofocus_cb), dialog);
-		gtk_widget_modify_text(dialog->screenname_entry,GTK_STATE_NORMAL,&color);
-	}
-
 	g_signal_connect(G_OBJECT(dialog->screenname_entry), "changed",
 					 G_CALLBACK(screenname_changed_cb), dialog);
 

mercurial