changelog
- Fri, 12 Jul 2024 19:57:40 -0500
- by Gary Kramlich <grim@reaperworld.com> [Fri, 12 Jul 2024 19:57:40 -0500] rev 42813
- Remove Purple.Conversation.send and Purple.Conversation.send_with_flags
Technically speaking we lost support for auto linkifying, but we don't need a
flag for this, the protocol should just do that if it needs to.
Testing Done:
Ran the turtles.
Reviewed at https://reviews.imfreedom.org/r/3288/
- Fri, 12 Jul 2024 19:56:17 -0500
- by Gary Kramlich <grim@reaperworld.com> [Fri, 12 Jul 2024 19:56:17 -0500] rev 42812
- Update Pidgin.Conversation to use Purple.Conversation.send_message_async
This was the last thing using purple_conversation_send which we want to remove.
Testing Done:
Send messages in a channel and a dm without issue and ran the turtles.
Reviewed at https://reviews.imfreedom.org/r/3287/
- Fri, 12 Jul 2024 19:53:44 -0500
- by Gary Kramlich <grim@reaperworld.com> [Fri, 12 Jul 2024 19:53:44 -0500] rev 42811
- Reparent Purple.Account from Purple.ContactInfo to GLib.Object
Testing Done:
Ran the turtles and connected a demo and ircv3 account sent some messages and closed and reopened the app without issue.
Reviewed at https://reviews.imfreedom.org/r/3286/
- Fri, 12 Jul 2024 00:13:26 -0500
- by Gary Kramlich <grim@reaperworld.com> [Fri, 12 Jul 2024 00:13:26 -0500] rev 42810
- 2.x.y: Update the build image for the docs
I deleted the repo for the bookworm builder not realizing that it was used to
build the docs. Luckily, the trixie image works just fine.
Testing Done:
ran the `docs` convey plan.
Reviewed at https://reviews.imfreedom.org/r/3285/
- Tue, 09 Jul 2024 02:07:56 -0500
- by Gary Kramlich <grim@reaperworld.com> [Tue, 09 Jul 2024 02:07:56 -0500] rev 42809
- Add Yoann Congal to COPYRIGHT
- Tue, 09 Jul 2024 02:03:20 -0500
- by Yoann Congal <yoann.congal@smile.fr> [Tue, 09 Jul 2024 02:03:20 -0500] rev 42808
- Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14
The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks
(aka void (*)(void)) but is initialised with GtkItemFactoryCallback1 types
(aka void (*)(void *, guint, GtkWidget *)).
This is coherent with the gtk-2 documentation:
> gtk_item_factory_create_items(..., GtkItemFactoryEntry *entries,...)
> entries : an array of GtkItemFactoryEntrys whose callback members must by of
> type GtkItemFactoryCallback1
But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to
GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [gcc-doc]).
An exemple of this error:
pidgin/gtkconv.c:3096:66: error: initialization of 'void (*)(void)' from incompatible pointer type 'void (*)(void *, guint, GtkWidget *)' {aka 'void (*)(void *, unsigned int, struct _GtkWidget *)'} [-Wincompatible-pointer-types]
3096 | { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb,
| ^~~~~~~~~~~~~~~~
pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback')
To fix this, explicitely cast to GtkItemFactoryCallback where needed.
[0]: https://gcc.gnu.org/gcc-14/porting_to.html#incompatible-pointer-types
Testing Done:
Built with gcc-14, started and clicked on some affected menus
Reviewed at https://reviews.imfreedom.org/r/3282/
- Mon, 08 Jul 2024 00:54:25 -0500
- by Gary Kramlich <grim@reaperworld.com> [Mon, 08 Jul 2024 00:54:25 -0500] rev 42807
- 2.x.y: Add convey plans for debian trixie and fedora 40
Testing Done:
Built the images locally before running the plans locally.
Reviewed at https://reviews.imfreedom.org/r/3283/
- Thu, 04 Jul 2024 00:43:16 -0500
- by Markus Fischer <ivanhoe@fiscari.de> [Thu, 04 Jul 2024 00:43:16 -0500] rev 42806
- Use global conversation id for SQLite history adapter
This solves an error I'm getting when writing a message in the demo protocol plugin.
```
history manager write returned error: Error writing to the database: NOT NULL constraint failed: message_log.conversation_id
```
Testing Done:
Wrote a message to a demo contact.
Reviewed at https://reviews.imfreedom.org/r/3277/
- Thu, 27 Jun 2024 00:48:00 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 27 Jun 2024 00:48:00 -0500] rev 42805
- Update libpurple to use get id and username directly on PurpleAccount
This is part of making PurpleAccount have a PurpleContactInfo instead of being
one.
Testing Done:
Ran the turtles and opened Pidgin 3 with some accounts without issue.
Reviewed at https://reviews.imfreedom.org/r/3274/
- Thu, 27 Jun 2024 00:46:27 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 27 Jun 2024 00:46:27 -0500] rev 42804
- Update pidgin to use get id and username directly on PurpleAccount
This is part of making PurpleAccount have a PurpleContactInfo instead of being
one.
Testing Done:
Ran the turtles, connected some accounts, disabled one via the menu and re-enabled it.
Reviewed at https://reviews.imfreedom.org/r/3273/
